Fix and extend tests #48
Conversation
- Import statements outdated - Adapter choices weren't appropriate - `Mapper` call changed - `test_get_sequence_name` needs to be checked for consistency with requirements but has been updated to succeed.
- Import statements outdated - Adapter choices weren't appropriate - `Mapper` call changed - `test_get_sequence_name` needs to be checked for consistency with requirements but has been updated to succeed.
|
It seems that tests are failing in |
|
I also don't understand what is happening. The tests fail for python 3.8 and 3.10 for different reasons. I tried to fix the |
- Import statements outdated - Adapter choices weren't appropriate - `Mapper` call changed - `test_get_sequence_name` needs to be checked for consistency with requirements but has been updated to succeed.
- Import statements outdated - Adapter choices weren't appropriate - `Mapper` call changed - `test_get_sequence_name` needs to be checked for consistency with requirements but has been updated to succeed.
henhuy
force-pushed
the
fix-and-extend-tests
branch
from
bb186f1
to
aa05500
Compare
|
@FelixMau can you please check on the missing The list of ~300 mapping-warnings is impressive. Maybe we should specify these, with information about the process name to make them more usefull? |
Do you mean because of missing period merging? I think we have to decide on how the inputs should look like first (in #45)
Yes indeed impressive and less usefull, will have a look into that! |
Because of the missing |
…nd-extend-tests # Conflicts: # tests/_files/build_datapackage_goal/datapackage.json # tests/test_build_datapackage.py # tests/test_mapping.py
Is pytest "allowed to mkdir" on github tests?
|
| @@ -152,7 +155,8 @@ def get_foreign_keys(struct: list, mapper: Mapper, components: list) -> list: | |||
| } | |||
| ) | |||
| else: | |||
| # Most likely the field may be a Timeseries in this case, but it is a scalar or unused. | |||
| # Most likely the field may be a Timeseries in this case, but it | |||
There was a problem hiding this comment.
This comment is a bit confusing, improve or remove?
Closes #43
Please note that two test cannot be completed yet since they depend on changes from other branches and modules.
test_build_tabular_datapackage_from_adapterrequires changes indata_adapterto receive only one column pernameand moreover needs refactoring from Merge and write periods #45 for MultiIndex Timerseries data (@henhuy if this is still required after updatingdata_adapter?)test_read_datapackageRelies on Implementing Multiperiod functionality for Scalar values first.